Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Libraries R2R Testing in CI #83854

Closed
wants to merge 4 commits into from
Closed

Enable Libraries R2R Testing in CI #83854

wants to merge 4 commits into from

Conversation

ivdiazsa
Copy link
Member

@ivdiazsa ivdiazsa commented Mar 23, 2023 •
edited
Loading

This PR is a follow-up to #80946. Now that we have TestReadyToRun enabled for the appropriate libraries tests (done in the aforementioned PR), we can add it to our CI, so these tests can get run regularly. Currently a WIP.

@ghost ghost assigned ivdiazsa Mar 23, 2023
@ghost
Copy link

ghost commented Mar 23, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is a follow-up to #80946. Now that we have TestReadyToRun enabled for the appropriate libraries tests (done in the aforementioned PR), we can add it to our CI, so these tests can get run regularly.

Author: ivdiazsa
Assignees: ivdiazsa
Labels:

area-Infrastructure-libraries
Milestone: -

@ivdiazsa
Copy link
Member Author

@trylek Here's my initial attempt on adding the TestReadyToRun legs to the pipelines.

@ghost
Copy link

ghost commented Mar 23, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR is a follow-up to #80946. Now that we have TestReadyToRun enabled for the appropriate libraries tests (done in the aforementioned PR), we can add it to our CI, so these tests can get run regularly. Currently a WIP.

Author: ivdiazsa
Assignees: ivdiazsa
Labels:

area-Infrastructure
Milestone: -

@build-analysis build-analysis bot mentioned this pull request Mar 24, 2023
Closed
@trylek
Copy link
Member

trylek commented Mar 24, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@trylek
Copy link
Member

trylek commented Mar 24, 2023 •
edited
Loading

@ivdiazsa - I have triggered the runtime-extra-platforms pipeline and the new tests have trouble building, there seem to be some versioning shenanigans going on. I vaguely recall Simon Nattress fought similar issues, perhaps we need to set the __TestDotNetCmd variable?

@trylek
Copy link
Member

trylek commented Mar 24, 2023

Interestingly enough the runtime-extra-platforms is now failing even in NativeAOT legs, at the first glance I don't see how that can be related to Ivan's R2R changes, it looks like some dependency issue, @MichalStrehovsky - do you have any ideas what might be going on?

EXEC : error : Failed to load assembly 'SQLitePCLRaw.core' [D:\a\_work\1\s\src\libraries\Microsoft.Extensions.Configuration.Binder\tests\SourceGenerationTests\Microsoft.Extensions.Configuration.Binder.SourceGeneration.Tests.csproj::TargetFramework=net8.0]
##[error]EXEC(0,0): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Failed to load assembly 'SQLitePCLRaw.core'
  Internal.TypeSystem.TypeSystemException+FileNotFoundException: Failed to load assembly 'SQLitePCLRaw.core'
     at Internal.TypeSystem.ThrowHelper.ThrowFileNotFoundException(ExceptionStringID, String) + 0x30
     at Internal.TypeSystem.ResolutionFailure.Throw() + 0xf8
     at Internal.TypeSystem.Ecma.EcmaModule.GetObject(EntityHandle, NotFoundBehavior) + 0x95
     at Internal.TypeSystem.Ecma.EcmaSignatureParser.ResolveHandle(EntityHandle) + 0x1c
     at Internal.TypeSystem.Ecma.EcmaSignatureParser.ParseTypeImpl(SignatureTypeCode) + 0x96
     at Internal.TypeSystem.Ecma.EcmaSignatureParser.ParseType(SignatureTypeCode) + 0x43
     at Internal.TypeSystem.Ecma.EcmaSignatureParser.ParseType() + 0x4c
     at Internal.TypeSystem.Ecma.EcmaSignatureParser.ParseFieldSignature() + 0x38
     at Internal.TypeSystem.Ecma.EcmaField.InitializeFieldType() + 0x12a
     at Internal.TypeSystem.MetadataFieldLayoutAlgorithm.ComputeInstanceLayout(DefType, InstanceLayoutKind) + 0x149
     at Internal.TypeSystem.DefType.ComputeInstanceLayout(InstanceLayoutKind) + 0x5d
     at ILCompiler.CompilerTypeSystemContext.EnsureLoadableTypeUncached(TypeDesc) + 0x43c
     at Internal.TypeSystem.LockFreeReaderHashtable`2.CreateValueAndEnsureValueIsInTable(TKey) + 0x11
     at ILCompiler.DependencyAnalysis.EETypeNode..ctor(NodeFactory, TypeDesc) + 0x14b
     at ILCompiler.DependencyAnalysis.NodeFactory.CreateNecessaryTypeNode(TypeDesc) + 0xf1
     at Internal.TypeSystem.LockFreeReaderHashtable`2.CreateValueAndEnsureValueIsInTable(TKey) + 0x11
     at ILCompiler.DependencyAnalysis.NodeFactory.NecessaryTypeSymbol(TypeDesc) + 0x95
     at ILCompiler.DependencyAnalysis.GenericCompositionNode.GetDehydratableData(NodeFactory, Boolean) + 0x1ee
     at ILCompiler.DependencyAnalysis.DehydratableObjectNode.GetData(NodeFactory, Boolean) + 0x26
     at ILCompiler.DependencyAnalysis.ObjectNode.GetStaticDependencies(NodeFactory) + 0x32
     at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.GetStaticDependenciesImpl(DependencyNodeCore`1) + 0x44
     at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.GetStaticDependencies(DependencyNodeCore`1) + 0x32
     at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ProcessMarkStack() + 0xb5
     at ILCompiler.DependencyAnalysisFramework.DependencyAnalyzer`2.ComputeMarkedNodes() + 0x4e
     at ILCompiler.ILScanner.ILCompiler.IILScanner.Scan() + 0x14
     at ILCompiler.Program.g__RunScanner|3_0(Program.<>c__DisplayClass3_0&) + 0x108
     at ILCompiler.Program.Run() + 0x1519
     at ILCompiler.ILCompilerRootCommand.<>c__DisplayClass206_0.<.ctor>b__0(InvocationContext context) + 0x20c

This was referenced Mar 25, 2023
Closed
Closed
Open
@ivdiazsa ivdiazsa closed this Apr 11, 2023
@ivdiazsa ivdiazsa reopened this Apr 11, 2023
@ivdiazsa
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Apr 12, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 12, 2023
Closed
@ivdiazsa
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa ivdiazsa linked an issue Apr 26, 2023 that may be closed by this pull request
Add TestReadyToRun Leg to CI #85417
Closed
This was referenced Apr 27, 2023
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 27, 2023
Open
@ghost ghost closed this Jun 3, 2023
@ghost
Copy link

ghost commented Jun 3, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ivdiazsa ivdiazsa reopened this Jun 12, 2023
@ghost ghost closed this Jul 13, 2023
@ghost
Copy link

ghost commented Jul 13, 2023

Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it.

@ivdiazsa ivdiazsa removed a link to an issue Jul 24, 2023
Add TestReadyToRun Leg to CI #85417
Closed
@ivdiazsa ivdiazsa mentioned this pull request Jul 24, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ivdiazsa ivdiazsa

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivdiazsa @trylek @carlossanlop